Increase gfx942 CU count to 96 for UNROLL=4 #1302
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nileshnegi
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd and
haripriya-amd
as code owners
wenkaidu
approved these changes
Aug 15, 2024
nileshnegi
force-pushed
the
topic/unroll4-96CU
branch
2 times, most recently
from
50b22b9 to
7cb60be
Compare
Signed-off-by: nileshnegi <[email protected]>
Signed-off-by: nileshnegi <[email protected]>
nileshnegi
force-pushed
the
topic/unroll4-96CU
branch
from
7cb60be to
2e0943f
Compare
wenkaidu
reviewed
Aug 27, 2024
| ((comm->topo->nodes[GPU].nodes[0].gpu.cu == 80 || comm->topo->nodes[GPU].nodes[0].gpu.cu == 20 || comm->topo->nodes[GPU].nodes[0].gpu.cu == 38) | ||
| ((comm->topo->nodes[GPU].nodes[0].gpu.cu == 38 || | ||
| comm->topo->nodes[GPU].nodes[0].gpu.cu == 80 || comm->topo->nodes[GPU].nodes[0].gpu.cu == 20 || | ||
| comm->topo->nodes[GPU].nodes[0].gpu.cu == 96 || comm->topo->nodes[GPU].nodes[0].gpu.cu == 24) |
There was a problem hiding this comment.
With #1310, we can use std::min(comm->topo->nodes[GPU].nodes[0].gpu.cu, MAXCHANNELS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
Work item:
Internal
What were the changes?
Use
UNROLL=4for gfx942 and up to 96 CUsWhy were the changes made?
Improve performance
Approval Checklist
Do not approve until these items are satisfied.